Discussion:
[PATCH] gdhcp:Remove unnecessary check
(too old to reply)
Maneesh Jain
2015-10-05 10:35:42 UTC
Permalink
Signed-off-by: Maneesh Jain <***@samsung.com>
---
gdhcp/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdhcp/client.c b/gdhcp/client.c
index 3c11957..cb4bcb4 100755
--- a/gdhcp/client.c
+++ b/gdhcp/client.c
@@ -2349,7 +2349,7 @@ static gboolean listener_event(GIOChannel *channel, GIOCondition condition,
return TRUE;
}

- if (!message_type && !client_id)
+ if (!message_type)
/* No message type / client id option, ignore package */
return TRUE;
--
1.9.1
Patrik Flykt
2015-10-08 07:15:38 UTC
Permalink
Please explain in the commit message *why* the client_id check is
unnecessary. Quickly looking at the code doesn't immediately reveal the
reasoning behind this check.

No signed-off-bys either.
Post by Maneesh Jain
---
gdhcp/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdhcp/client.c b/gdhcp/client.c
index 3c11957..cb4bcb4 100755
--- a/gdhcp/client.c
+++ b/gdhcp/client.c
@@ -2349,7 +2349,7 @@ static gboolean listener_event(GIOChannel *channel, GIOCondition condition,
return TRUE;
}
- if (!message_type && !client_id)
+ if (!message_type)
/* No message type / client id option, ignore package */
return TRUE;
Patrik

Loading...